move tscoverage en/decoders from riak_kv over here #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anticipating get_coverage conversion to TTB, where native terms are sent over the wire, riak_kv_ts_svc needs to be agnostic to all internals of #ts* structures except for the top-level tags. This commit introduces the only remaining instance of such usage.
|
Seems fine to me. Someone with more experience in coverage queries should review. |
| %% Copied and modified from riak_kv_pb_coverage:convert_list. Would | ||
| %% be nice to collapse them back together, probably with a closure, | ||
| %% but time and effort. | ||
| encode_cover_list(Entries) -> |
There was a problem hiding this comment.
We generally try to make sure exported functions have specs. Internal ones are less important.
This was referenced Apr 17, 2016
hmmr
force-pushed
the
fix-az-move_coverage_codec_from_riak_kv_to_tb
branch
from
3a6b009
to
3d68557
Compare
|
👍 3d68557 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the code assembling
#tscoveragerespfrom riak_kv here. The callbacks in the common module serving both PB and TTB messages need to only ever return plain Erlang terms. For PB messages, appropriate codecs will be used (fromriak_pb_ts_codec), while TTB messages are transmitted (as if) without any conversions.This PR is required for basho/riak_kv#1382 and basho/riak-erlang-client#277 to pass the tests in basho/riak_test#1037.